Ticket #100 (closed defect: fixed)

Opened 16 months ago

Last modified 16 months ago

Discard button icon missing – 0.7.2

Reported by: budulay Owned by: TomPh
Priority: minor Component: main application
Version: Severity: harmless
Keywords: Cc:


Discard button icon is missing in in the configuration menu.

All the other icons are in place.

I have gtk-discard_20.png in /usr/share/pixmaps/emelfm2.

Compiled from source on VectorLinux? 6.0 Light with prefix=/usr/share/emelfm2


discard_button.jpg (26.4 kB) – added by budulay 16 months ago.

Change History

Changed 16 months ago by TomPh

  • status changed from new to accepted

Do you mean the button in the configuration dialog? Or some other menu ? If so, which one ?

Changed 16 months ago by budulay

Changed 16 months ago by budulay

It’s the discard button in the configuration dialog. I’ve attached a screenshot.

Changed 16 months ago by budulay

just noticed that the icon is also missing in the confirm dialog(when I edit a file with F4 and then quit the editing without saving it, the dialog pops up asking me to save, discard changes or cancel the quit).

Changed 16 months ago by TomPh

OK, it’s only in buttons, not in something you’ve configured yourself.

The discard icon is actually a stock gtk icon, supposed to be available since gtk 2.14. In practice, gtk has never (to now) actually included such an icon, and I suspect that icon-themers don’t bother either. During an emelfm2 session, the discard icon provided with emelfm2 is registered as a gtk stock icon, if a discard icon is not then available from gtk. This process was intended to be a temporary workaround until gtk got its act together, but maybe that’ll never happen. I submitted the icon to gtk bugzilla, but the devs seem to have no interest in this.

Anyway, two possibilities occur to me:
1. your system reports that it can already access a GTK_STOCK_DISCARD, even when it’s blank or something, and therefore the emelfm2 icon is not registered. If this is the case, then I can’t think of anything we can do about it.
2. the registration process is not working properly. You mentioned that you have
/usr/share/pixmaps/emelfm2/gtk-discard_20.png. What is your #define for ICON_DIR in file
… src/build/build.h ? It would need to be consistent i.e. /usr/local/share/pixmaps/emelfm2

Changed 16 months ago by budulay

  • status changed from accepted to closed
  • resolution set to fixed

The #define path was wrong.
I recompiled with PREFIX=/usr/ and it found all the icons right away.

The strange thing is, I set the icon directory to /usr/share/pixmaps/emelfm2 under the interface tab, and it found all of them except for the discard one.

Thank you for your help and sorry for bothering you with such a silly problem.
And thanks a lot for bringing us this awesome file manager.

Will reupload the package to the repository now.

Changed 16 months ago by TomPh

The strange thing is… FYI, presumably you had compiled it for some ‘preface’ other than /usr, and installed, and defaulted to looking for, all custom icons accordingly. But in your config you over-rode the default with /usr…, probably associated with some older installation, where there was no discard icon until your latest build and install. HTH

Changed 16 months ago by budulay

Well, actually I did make install with a different prefix than make(not even sure how I came up with that). So I had all the icons in /usr/share/pixmaps/emelfm2 , including the discard one. But then I had to use custom icon directory to get all the icons working, and on top of that enable all the plugins manually. In the end everything worked but the discard icon.

Note: See TracTickets for help on using tickets.